Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHS-5693: Vertical Button Card link color fix in warbler #1586

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

cienvaras
Copy link
Collaborator

READY FOR REVIEW

Summary

  • Fix color of links in vertical color cards when using warbler color pairing

Need Review By (Date)

07/31

Urgency

high

Steps to Test

In a site with traditional theme:

  1. Switch color pairing to warbler
  2. Create a flexible page, add a collection with two postcards, both with the style field set to "Vertical Button Card", one with an internal link and the other with an external link.
  3. Save the node and visit the page. Confirm that the card links look as expected for both internal and external links (see screenshots below)

Default state

Screenshot 2024-07-30 at 6 51 55 PM

hover and focus

Screenshot 2024-07-30 at 6 52 03 PM

PR Checklist

@cienvaras cienvaras assigned cienvaras and unassigned cienvaras Jul 31, 2024
@cienvaras cienvaras requested a review from joegl July 31, 2024 00:53
@cienvaras
Copy link
Collaborator Author

@joegl Here's the fix for a small color issue we found in the new vertical cards variant today in the demo. Can you please help us with a review? Thanks!

@joegl joegl merged commit 2190e1f into 11.1.4-release Jul 31, 2024
16 checks passed
@joegl joegl deleted the shs-5693--warbler-button-color-fix branch July 31, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants